Force refetching source if our cached copy will expire#44
Open
ghalse wants to merge 1 commit intosimplesamlphp:masterfrom
Open
Force refetching source if our cached copy will expire#44ghalse wants to merge 1 commit intosimplesamlphp:masterfrom
ghalse wants to merge 1 commit intosimplesamlphp:masterfrom
Conversation
If we set the `expiresAfter` option in metarefresh's config, we effectively alter the inbound metadata. Thus when we're conditionally GETting, we need to be aware that we've introduced a validUntil attribute that the remote server may not know about. That means we might need to force a refresh of the source even if the remote server does not think it has been modified.
ghalse
commented
Apr 30, 2025
Author
ghalse
left a comment
ghalse
left a comment
There was a problem hiding this comment.
Because metarefresh is typically called periodically by cron, we can't force the refresh at exactly the expiry time. To avoid metadata expiring between calls, we need a bit of a buffer. The choice of one hour for the buffer is essentially arbitrary, but based on the example config setting 'cron' => ['hourly'].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set the
expiresAfteroption in metarefresh's config, we effectively alter the inbound metadata. Thus when we're conditionally GETting, we need to be aware that we've introduced a validUntil attribute that the remote server may not know about. That means we might need to force a refresh of the source even if the remote server does not think it has been modified.